IGNITE-28515 : Use MessageSerializer for QueryIndex - copy#13058
Open
Vladsz83 wants to merge 13 commits intoapache:masterfrom
Open
IGNITE-28515 : Use MessageSerializer for QueryIndex - copy#13058Vladsz83 wants to merge 13 commits intoapache:masterfrom
Vladsz83 wants to merge 13 commits intoapache:masterfrom
Conversation
# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/processors/query/schema/operation/SchemaIndexCreateOperation.java
…-28515-QueryIndex
# Conflicts: # modules/core/src/main/java/org/apache/ignite/internal/CoreMessagesProvider.java
|
anton-vinogradov
approved these changes
Apr 21, 2026
| break; | ||
|
|
||
| case 10910: { | ||
| case 10911: { |
Contributor
There was a problem hiding this comment.
@Vladsz83 @anton-vinogradov , now it looks very ugly that we need to do this. It is necessary to refactor this case block.
Contributor
Author
There was a problem hiding this comment.
We should use smth. like msgFactory.messageType(msg). Looks like other ticket. Or I could place the message below in the registration list. But I could place it where it should be and make a fix.
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.